Skip to content

fix: fix potential OOM involving snappy data, found by fuzzer #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 30, 2022
Merged

fix: fix potential OOM involving snappy data, found by fuzzer #141

merged 1 commit into from
May 30, 2022

Conversation

crepererum
Copy link
Collaborator

alamb
alamb approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it need a test too? Or maybe fuzzing is sufficient

src/protocol/record.rs
let chunk_length = u32::from_be_bytes(buf_chunk_length) as usize;
let bytes_left = cursor_content.len() - (cursor.position() as usize);
if chunk_length > bytes_left {
// do NOT try to allocate massive buffer for `chunk_data` but instead fail early
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

domodwyer
domodwyer approved these changes May 30, 2022
View reviewed changes
Copy link
Contributor

@domodwyer domodwyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more spam!

@crepererum
Copy link
Collaborator Author

Does it need a test too?

I think I can extract a test case 👍

@crepererum crepererum force-pushed the crepererum/fix_snappy_oom branch from a0b76ad to 5f597bd Compare May 30, 2022 15:14
@crepererum
Copy link
Collaborator Author

added a test

@crepererum crepererum added the automerge Instruct kodiak to merge the PR label May 30, 2022
@kodiakhq kodiakhq bot merged commit 822186d into main May 30, 2022
@kodiakhq kodiakhq bot deleted the crepererum/fix_snappy_oom branch May 30, 2022 15:18
alamb
alamb reviewed May 31, 2022
View reviewed changes
src/protocol/record.rs
]
.to_vec();

let err = RecordBatchBody::read(&mut Cursor::new(data)).unwrap_err();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alamb alamb alamb approved these changes

+1 more reviewer

@domodwyer domodwyer domodwyer approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
automerge Instruct kodiak to merge the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@crepererum @alamb @domodwyer